From a2e5e5f3a84e69815646ab11715478815c144ba6 Mon Sep 17 00:00:00 2001 From: Sam Light Date: Sat, 19 Apr 2025 09:45:33 +0100 Subject: Improve acceess log middleware handling of properties --- src/Http/AccessLogMiddleware.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/Http/AccessLogMiddleware.php b/src/Http/AccessLogMiddleware.php index 67cc8a4..419398e 100644 --- a/src/Http/AccessLogMiddleware.php +++ b/src/Http/AccessLogMiddleware.php @@ -11,7 +11,7 @@ use Closure; class AccessLogMiddleware { - protected function properties(Request $request, Response $response): ?iterable + protected function properties(Request $request, Response $response): iterable { $props = []; @@ -27,7 +27,7 @@ class AccessLogMiddleware $props['user_agent'] = $request->userAgent(); } - return empty($props) ? null : $props; + return $props; } protected function shouldLog(Request $request): bool @@ -40,11 +40,12 @@ class AccessLogMiddleware protected function createLog(Request $request, Response $response): void { $model = config('access_log.model'); + $props = $this->properties($request, $response); $log = new $model([ 'path' => $request->path(), 'status' => $response->status(), 'method' => $request->method(), - 'properties' => $this->properties($request, $response), + 'properties' => empty($props) ? null : $props, ]); $log->user()->associate($request->user()); $log->save(); -- cgit v1.2.3