diff options
| author | Devian <devianleong@gmail.com> | 2021-04-28 12:43:18 +0800 |
|---|---|---|
| committer | Devian <devianleong@gmail.com> | 2021-04-28 12:43:18 +0800 |
| commit | c6e582faeefab0f015ad997e441f4e6e3bd0c6a2 (patch) | |
| tree | b5becb0d08a6565e0dbdc640f039281f5c8ec674 /src/Manager/ScormManager.php | |
| parent | 628b14c5bf771310897316710894d8a0d0aaa36a (diff) | |
Sanitize score
Diffstat (limited to 'src/Manager/ScormManager.php')
| -rw-r--r-- | src/Manager/ScormManager.php | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/Manager/ScormManager.php b/src/Manager/ScormManager.php index f26bc15..7813ad6 100644 --- a/src/Manager/ScormManager.php +++ b/src/Manager/ScormManager.php @@ -373,10 +373,10 @@ class ScormManager // Update best score if the current score is better than the previous best score - if (empty($bestScore) || (!is_null($scoreRaw) && $scoreRaw > $bestScore)) { - $tracking->setScoreRaw($scoreRaw); - $tracking->setScoreMin($scoreMin); - $tracking->setScoreMax($scoreMax); + if (empty($bestScore) || (!is_null($scoreRaw) && (int)$scoreRaw > (int)$bestScore)) { + $tracking->setScoreRaw((int)$scoreRaw); + $tracking->setScoreMin((int)$scoreMin); + $tracking->setScoreMax((int)$scoreMax); } if (empty($bestStatus) || ($lessonStatus !== $bestStatus && $statusPriority[$lessonStatus] > $statusPriority[$bestStatus])) { @@ -431,10 +431,10 @@ class ScormManager $tracking->setTotalTimeString($totalTimeInterval); // Update best score if the current score is better than the previous best score - if (empty($bestScore) || (!is_null($scoreRaw) && $scoreRaw > $bestScore)) { - $tracking->setScoreRaw($scoreRaw); - $tracking->setScoreMin($scoreMin); - $tracking->setScoreMax($scoreMax); + if (empty($bestScore) || (!is_null($scoreRaw) && (int)$scoreRaw > (int)$bestScore)) { + $tracking->setScoreRaw((int)$scoreRaw); + $tracking->setScoreMin((int)$scoreMin); + $tracking->setScoreMax((int)$scoreMax); $tracking->setScoreScaled($scoreScaled); } |