summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDevian <devianleong@gmail.com>2021-04-23 11:29:52 +0800
committerDevian <devianleong@gmail.com>2021-04-23 11:29:52 +0800
commit5d6e7826f6e444136daa972a2acebd5381a9ada3 (patch)
tree33ea603f1bea4edfa02bbd963244c3476c6dc0c7 /src
parent26e4f3a8b28b3f7531042e2ae62f943dcac9ba15 (diff)
Added carbon
Diffstat (limited to 'src')
-rw-r--r--src/Entity/ScoTracking.php4
-rw-r--r--src/Manager/ScormManager.php8
2 files changed, 5 insertions, 7 deletions
diff --git a/src/Entity/ScoTracking.php b/src/Entity/ScoTracking.php
index aa58fe5..f15231f 100644
--- a/src/Entity/ScoTracking.php
+++ b/src/Entity/ScoTracking.php
@@ -4,6 +4,8 @@
namespace Peopleaps\Scorm\Entity;
+use Carbon\Carbon;
+
class ScoTracking
{
public $userId;
@@ -244,7 +246,7 @@ class ScoTracking
return $this->latestDate;
}
- public function setLatestDate(\DateTime $latestDate = null)
+ public function setLatestDate(Carbon $latestDate = null)
{
$this->latestDate = $latestDate;
}
diff --git a/src/Manager/ScormManager.php b/src/Manager/ScormManager.php
index 055d3be..ae2e827 100644
--- a/src/Manager/ScormManager.php
+++ b/src/Manager/ScormManager.php
@@ -285,7 +285,7 @@ class ScormManager
$scoTracking->setLessonMode($storeTracking->lesson_mode);
$scoTracking->setIsLocked($storeTracking->is_locked);
$scoTracking->setDetails($storeTracking->details);
- $scoTracking->setLatestDate($storeTracking->latest_date);
+ $scoTracking->setLatestDate(Carbon::parse($storeTracking->latest_date));
return $scoTracking;
}
@@ -293,7 +293,7 @@ class ScormManager
public function updateScoTracking($scoUuid, $userId, $data)
{
$tracking = $this->createScoTracking($scoUuid, $userId);
- $tracking->setLatestDate(new \DateTime());
+ $tracking->setLatestDate(Carbon::now());
$sco = $tracking->getSco();
$scorm = ScormModel::where('id', $sco['id'])->firstOrFail();
@@ -338,10 +338,6 @@ class ScormManager
$bestStatus = $tracking->getLessonStatus();
// Update best score if the current score is better than the previous best score
- if (empty($bestScore) || (!is_null($scoreRaw) && $scoreRaw > $bestScore)) {
- $tracking->setScoreRaw($scoreRaw);
- $bestScore = $scoreRaw;
- }
if (empty($bestScore) || (!is_null($scoreRaw) && $scoreRaw > $bestScore)) {
$tracking->setScoreRaw($scoreRaw);