From c6e582faeefab0f015ad997e441f4e6e3bd0c6a2 Mon Sep 17 00:00:00 2001 From: Devian Date: Wed, 28 Apr 2021 12:43:18 +0800 Subject: Sanitize score --- src/Manager/ScormManager.php | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Manager/ScormManager.php b/src/Manager/ScormManager.php index f26bc15..7813ad6 100644 --- a/src/Manager/ScormManager.php +++ b/src/Manager/ScormManager.php @@ -373,10 +373,10 @@ class ScormManager // Update best score if the current score is better than the previous best score - if (empty($bestScore) || (!is_null($scoreRaw) && $scoreRaw > $bestScore)) { - $tracking->setScoreRaw($scoreRaw); - $tracking->setScoreMin($scoreMin); - $tracking->setScoreMax($scoreMax); + if (empty($bestScore) || (!is_null($scoreRaw) && (int)$scoreRaw > (int)$bestScore)) { + $tracking->setScoreRaw((int)$scoreRaw); + $tracking->setScoreMin((int)$scoreMin); + $tracking->setScoreMax((int)$scoreMax); } if (empty($bestStatus) || ($lessonStatus !== $bestStatus && $statusPriority[$lessonStatus] > $statusPriority[$bestStatus])) { @@ -431,10 +431,10 @@ class ScormManager $tracking->setTotalTimeString($totalTimeInterval); // Update best score if the current score is better than the previous best score - if (empty($bestScore) || (!is_null($scoreRaw) && $scoreRaw > $bestScore)) { - $tracking->setScoreRaw($scoreRaw); - $tracking->setScoreMin($scoreMin); - $tracking->setScoreMax($scoreMax); + if (empty($bestScore) || (!is_null($scoreRaw) && (int)$scoreRaw > (int)$bestScore)) { + $tracking->setScoreRaw((int)$scoreRaw); + $tracking->setScoreMin((int)$scoreMin); + $tracking->setScoreMax((int)$scoreMax); $tracking->setScoreScaled($scoreScaled); } -- cgit v1.2.3